Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thread safety to local cache #224

Merged
merged 5 commits into from
Jul 7, 2023
Merged

feat: add thread safety to local cache #224

merged 5 commits into from
Jul 7, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Jul 6, 2023

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 added enhancement New feature or request area/registry Persistence/Storage changes labels Jul 6, 2023
@ab93 ab93 self-assigned this Jul 6, 2023
ab93 added 3 commits July 6, 2023 15:22
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review July 6, 2023 22:59
@ab93 ab93 requested review from vigith and mboussarov July 6, 2023 22:59
Copy link
Collaborator

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ab93 ab93 merged commit 466681b into main Jul 7, 2023
8 checks passed
@ab93 ab93 deleted the threadsafe-cache branch July 7, 2023 00:33
ab93 added a commit that referenced this pull request Jul 10, 2023
- thread safety in LocalLRUCache since by default the cachetools classes
are not threadsafe:
https://cachetools.readthedocs.io/en/latest/#cache-implementations
- option to clear all instances in singleton metaclass

---------

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Persistence/Storage changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants