feat: use well-defined dimensions instead of strings #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
cosmic-chichu
requested review from
ab93,
qhuai,
nkoppisetty and
s0nicboOm
as code owners
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 93.29% 93.26% -0.03%
==========================================
Files 66 66
Lines 2909 2911 +2
Branches 233 234 +1
==========================================
+ Hits 2714 2715 +1
Misses 156 156
- Partials 39 40 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nkoppisetty
approved these changes
Sep 12, 2023
use generator Co-authored-by: Avik Basu <3485425+ab93@users.noreply.github.com> Signed-off-by: shrivardhan <shrivardhan92@gmail.com>
ab93
approved these changes
Sep 13, 2023
s0nicboOm
approved these changes
Sep 13, 2023
qhuai
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using dimensions as a list of strings causes ambiguity in other druid clients. Well-defined dimensions makes use of the utility in pydruid to create dimensions as DimensionSpec. This helps with deterministic serialization and de-serialization of the query.