refactor druid connector #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cosmic-chichu
commented
Sep 27, 2023
cosmic-chichu
commented
- use pydruid and not fork
- add support for doubles sketch aggregator and post aggregator
- add query timeout of 10 seconds
- fix logging
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
use generator Co-authored-by: Avik Basu <3485425+ab93@users.noreply.github.com> Signed-off-by: shrivardhan <shrivardhan92@gmail.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
Signed-off-by: Shrivardhan Rao <Shrivardhan_Rao@intuit.com>
cosmic-chichu
requested review from
ab93,
qhuai,
nkoppisetty and
s0nicboOm
as code owners
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 93.73% 93.81% +0.07%
==========================================
Files 74 77 +3
Lines 3447 3459 +12
Branches 277 277
==========================================
+ Hits 3231 3245 +14
Misses 161 161
+ Partials 55 53 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ab93
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.