Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker extra args error #302

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: docker extra args error #302

merged 1 commit into from
Sep 27, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Sep 27, 2023

Fix dockerfile arg scope issue where extra args were not getting installed

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Sep 27, 2023
@ab93 ab93 added the bug Something isn't working label Sep 27, 2023
@ab93 ab93 marked this pull request as ready for review September 27, 2023 23:20
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #302 (e4beeb9) into main (dfab26e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          77       77           
  Lines        3459     3459           
  Branches      277      277           
=======================================
  Hits         3248     3248           
  Misses        159      159           
  Partials       52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ab93 ab93 merged commit a0e0ad0 into main Sep 27, 2023
10 checks passed
@ab93 ab93 deleted the fix-docker-img branch September 27, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants