Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support both base conf and app conf #328

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat: support both base conf and app conf #328

merged 1 commit into from
Nov 30, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Nov 30, 2023

  • Add support for base config and app config merge
  • Throw an error if no conf exists
  • Paths can be altered using env vars

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Nov 30, 2023
@ab93 ab93 marked this pull request as ready for review November 30, 2023 02:01
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c967f20) 94.19% compared to head (6c99575) 93.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
numalogic/udfs/trainer/_prom.py 60.00% 14 Missing ⚠️
numalogic/connectors/redis.py 33.33% 1 Missing and 1 partial ⚠️
numalogic/udfs/__main__.py 87.50% 1 Missing ⚠️
numalogic/udfs/trainer/_base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   94.19%   93.78%   -0.42%     
==========================================
  Files          76       79       +3     
  Lines        3482     3570      +88     
  Branches      282      292      +10     
==========================================
+ Hits         3280     3348      +68     
- Misses        157      176      +19     
- Partials       45       46       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarabala1979
Copy link

sarabala1979 commented Nov 30, 2023

@ab93 Will Code load the new file if there is a config change?
similar numaproj/numalogic-prometheus#119

@ab93
Copy link
Member Author

ab93 commented Nov 30, 2023

@ab93 Will Code load the new file if there is a config change? similar numaproj/numalogic-prometheus#119

@sarabala1979 no it won't here. Added a new issue to track it.

@ab93 ab93 merged commit dfc383a into main Nov 30, 2023
10 checks passed
@ab93 ab93 deleted the custom-conf branch November 30, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants