Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo branch #335

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Demo branch #335

merged 5 commits into from
Dec 13, 2023

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Dec 13, 2023

Demo branch

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (28fa28f) 93.34% compared to head (e25b0d9) 93.48%.

Files Patch % Lines
numalogic/monitoring/metrics.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   93.34%   93.48%   +0.14%     
==========================================
  Files          82       82              
  Lines        3712     3731      +19     
  Branches      294      296       +2     
==========================================
+ Hits         3465     3488      +23     
+ Misses        196      193       -3     
+ Partials       51       50       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ab93 ab93 changed the base branch from main to tmp/mv-demo December 13, 2023 20:47
@ab93 ab93 marked this pull request as ready for review December 13, 2023 20:47
@ab93 ab93 merged commit 19ddc8e into numaproj:tmp/mv-demo Dec 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants