Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add max value map for cliping the value #339

Merged
merged 5 commits into from
Jan 18, 2024
Merged

fix: add max value map for cliping the value #339

merged 5 commits into from
Jan 18, 2024

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Jan 17, 2024

Add max_value_map for trainer

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review January 17, 2024 22:28
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (80ef431) 92.94% compared to head (5006847) 93.00%.

Files Patch % Lines
numalogic/udfs/trainer/_base.py 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   92.94%   93.00%   +0.05%     
==========================================
  Files          83       83              
  Lines        3812     3816       +4     
  Branches      302      304       +2     
==========================================
+ Hits         3543     3549       +6     
+ Misses        213      212       -1     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s0nicboOm s0nicboOm merged commit dbb510f into main Jan 18, 2024
10 of 11 checks passed
@s0nicboOm s0nicboOm deleted the clipper branch January 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants