Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take mean before calculating the thresholds #340

Merged
merged 2 commits into from
Jan 20, 2024
Merged

fix: take mean before calculating the thresholds #340

merged 2 commits into from
Jan 20, 2024

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Jan 19, 2024

take mean before calculating the thresholds

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm changed the title fix: take mean befroe calculating the thresholds fix: take mean before calculating the thresholds Jan 19, 2024
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review January 19, 2024 21:54
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbb510f) 92.92% compared to head (bb4ead2) 93.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   92.92%   93.00%   +0.07%     
==========================================
  Files          83       83              
  Lines        3816     3816              
  Branches      304      304              
==========================================
+ Hits         3546     3549       +3     
+ Misses        214      212       -2     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s0nicboOm s0nicboOm merged commit 870f263 into main Jan 20, 2024
11 checks passed
@s0nicboOm s0nicboOm deleted the fix_mean branch January 20, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants