Fix flatten vector. Stackup columnwise instead of row wise #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank10456
requested review from
ab93,
qhuai,
nkoppisetty and
s0nicboOm
as code owners
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
shashank10456
force-pushed
the
fix-flatten-vector
branch
from
aecc1ec
to
ffd84a0
Compare
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 93.40% 93.56% +0.15%
==========================================
Files 83 83
Lines 3853 3853
Branches 311 311
==========================================
+ Hits 3599 3605 +6
+ Misses 197 193 -4
+ Partials 57 55 -2 ☔ View full report in Codecov by Sentry. |
|
Can you make this parameter driven? |
ab93
reviewed
Feb 6, 2024
There was a problem hiding this comment.
@shashank10456 can you add unit test and assert the expected result?
added 6 commits
February 6, 2024 22:30
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Signed-off-by: ssrigiri1 <shashank_srigiri@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what this PR does.
Fix flatten vector. Stackup columnwise instead of row wise