feat: allow chunked druid fetch #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 92.31% 92.41% +0.09%
==========================================
Files 82 82
Lines 3918 3953 +35
Branches 325 331 +6
==========================================
+ Hits 3617 3653 +36
+ Misses 233 231 -2
- Partials 68 69 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
s0nicboOm
reviewed
Feb 23, 2024
s0nicboOm
reviewed
Feb 23, 2024
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
SaiSharathReddy
pushed a commit
to SaiSharathReddy/numalogic
that referenced
this pull request
Apr 29, 2024
Client side fetch time comparision: - Normal fetch, 72 hours: `0.35 s` - Chunked fetch, 72 hours, 6 hour chunk: `0.34 s` --------- Signed-off-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: skondakindi <saisharathreddy_kondakindi@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client side fetch time comparision:
0.35 s0.34 s