Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: old vanilla AE #368

Closed
wants to merge 22 commits into from
Closed

feat!: old vanilla AE #368

wants to merge 22 commits into from

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Apr 19, 2024

Summary of changes:

  • Change the order of postprocess operations; compute feature aggregation first, before postprocess
  • Introduce a robust scaling mechanism to lessen the effect of outliers in training

Config to be deployed:

model:
  name: LSTMAE
  conf:
    seq_len: 10
    no_features: 2
    embedding_dim: 2
    loss_fn: "mse"
    weight_decay: 1e-4
preprocess:
  - name: LogTransformer
    conf:
      add_factor: 2
  - name: PercentileScaler
    conf:
        max_percentile: 90
threshold:
  name: MaxPercentileThreshold
  conf:
    min_threshold: 0.1
trainer:
  batch_size: 256
  pltrainer_conf:
    accelerator: cpu
    max_epochs: 40
    deterministic: true
score:
  window_agg:
    method: EXP
    conf:
        beta: 0.85
  feature_agg:
    method: WEIGHTED_AVG
    conf:
        weights: [ 0.7, 0.3 ]

Image: quay.io/numaio/numalogic/udf:v0.9.1a0

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 74.17840% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 91.95%. Comparing base (f29f771) to head (b20f343).

Files Patch % Lines
numalogic/transforms/_scaler.py 33.33% 24 Missing ⚠️
numalogic/connectors/druid/_druid.py 53.33% 12 Missing and 2 partials ⚠️
numalogic/models/threshold/_median.py 45.45% 5 Missing and 1 partial ⚠️
numalogic/transforms/_postprocess.py 42.85% 4 Missing ⚠️
numalogic/backtest/_prom.py 82.35% 1 Missing and 2 partials ⚠️
numalogic/models/autoencoder/variants/vanilla.py 94.87% 0 Missing and 2 partials ⚠️
numalogic/udfs/postprocess.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   93.07%   91.95%   -1.13%     
==========================================
  Files          97       98       +1     
  Lines        4492     4612     +120     
  Branches      387      409      +22     
==========================================
+ Hits         4181     4241      +60     
- Misses        231      281      +50     
- Partials       80       90      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ab93 ab93 changed the title feat: add PercentileScaler feat!: add PercentileScaler Apr 19, 2024
@ab93 ab93 marked this pull request as ready for review April 19, 2024 02:51
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as draft April 21, 2024 21:23
Gulshan Bhatia and others added 2 commits April 22, 2024 15:19
Signed-off-by: Gulshan Bhatia <gulshan_bhatia@intuit.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 changed the title feat!: add PercentileScaler feat!: old vanilla AE Apr 26, 2024
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Static_filters support

---------

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
nkoppisetty and others added 2 commits May 2, 2024 17:20
Explain what this PR does.

Implemented pivot with multiple columns in druid connector

---------

Signed-off-by: Nandita Koppisetty <nandita.iitkgp@gmail.com>
Support for None for postproc.

---------

Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Explain what this PR does.

Changing pivot to pivot_table to support aggregation

---------

Signed-off-by: Nandita Koppisetty <nandita.iitkgp@gmail.com>
Explain what this PR does.

Adding agg to pivot config for multi pivot

---------

Signed-off-by: Nandita Koppisetty <nandita.iitkgp@gmail.com>
s0nicboOm and others added 4 commits May 8, 2024 10:49
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review May 8, 2024 20:39
@ab93
Copy link
Member Author

ab93 commented May 10, 2024

Closing

@ab93 ab93 closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants