Python 3.12 #1010
Merged
Python 3.12 #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1011 |
esc
force-pushed
the
py312
branch
2 times, most recently
from
e18d845
to
bbfd9a0
Compare
kc611
approved these changes
Nov 16, 2023
…e it This is needed for building via `setup.py`. The assumption is that this was always needed but `setuptools` had been installed by default so llvmlite just built "by accident". With 3.12 we discovered that this assumption no longer holds and so we must add `setuptools` to the build requirements explicitly. In addition the conda-recipe was using `python -s` to run the `setup.py` script which implies that packages from `site-packages` will not be loaded. This must therefore also be removed such that Windows can even find the installed `setuptools`.
As title
sklam
approved these changes
Nov 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title