Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported Python version to 3.9 #1018

Merged
merged 2 commits into from Dec 5, 2023
Merged

Conversation

kc611
Copy link
Collaborator

@kc611 kc611 commented Dec 4, 2023

As titled,

This PR bumps the supported Python version to 3.9.

@stuartarchibald
Copy link
Contributor

Thanks for the patch, suggest getting #1017 merged first and then review and fix up this one once the conflicts are resolved?

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Searching the code base for '3\s*8', '3\.8', '3,\s*8' this change seems to cover all the matched cases that apply. There's one comment RE wheel support (311 and 312 are missing, suggest resolving now?) else looks good.

@@ -29,7 +29,6 @@ The conda packages will be stored into `<llvmlite_source_root>/docker_output/dis

Available Python installations (`<pyver>`) are:

- cp38-cp38
- cp39-cp39
- cp310-cp310
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

311 and 312 are missing from here, perhaps add them whilst making this update?

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes!

@sklam sklam merged commit 927e430 into numba:main Dec 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants