Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda recipe: add make as build dep #400

Merged
merged 2 commits into from Oct 23, 2018

Conversation

nehaljwani
Copy link
Contributor

Don't assume that make is part of the build container

Don't assume that make is part of the build container
@codecov-io
Copy link

codecov-io commented Oct 6, 2018

Codecov Report

Merging #400 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #400      +/-   ##
=========================================
- Coverage   92.34%   92.3%   -0.04%     
=========================================
  Files          33      33              
  Lines        5159    5161       +2     
  Branches      358     360       +2     
=========================================
  Hits         4764    4764              
  Misses        320     320              
- Partials       75      77       +2

@coveralls
Copy link

coveralls commented Oct 6, 2018

Coverage Status

Coverage increased (+0.002%) to 93.771% when pulling 3d0a4ed on nehaljwani:make_build_dep into 80d8f86 on numba:master.

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, this is a good point. A minor change noted would also accommodate ARM.

conda-recipes/llvmlite/meta.yaml Outdated Show resolved Hide resolved
@stuartarchibald
Copy link
Contributor

Thanks for the fix up @nehaljwani, merging.

@stuartarchibald stuartarchibald merged commit a52ca0d into numba:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants