Add fp16 Intrinsics #510
Merged
Add fp16 Intrinsics #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njwhite
force-pushed
the
feature/fp16
branch
from
9e4763d
to
7fb13f8
Compare
njwhite
force-pushed
the
feature/fp16
branch
from
7fb13f8
to
154af26
Compare
|
CI failures seem spurious? |
| Convert from an i16 to the given FP type | ||
| """ | ||
| if not to: | ||
| raise TypeError("expected a float return type") |
There was a problem hiding this comment.
Is this branch exercised in the tests?
There was a problem hiding this comment.
I've added another test so all the error messages are covered now
|
This will also need a merge from master once the thing causing the test failures is fixed (probably #513) |
|
Close/Open to restart all of CI easily. Apologies for the noise. |
|
Thanks for the review @stuartarchibald, I've pushed fixes to address all your comments - |
stuartarchibald
approved these changes
Sep 30, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..because NVVM IR doesn't support half types!