Trove classifiers may be out of date. #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, and yes please, thanks. |
|
Can get rid of https://github.com/numba/llvmlite/blob/master/setup.py#L165-L166 whilst at it ? |
|
@stuartarchibald yeah, I saw that and considered it and will now include it. |
This is set to match the Python versions supported by Numba.
Since 3.4 is no longer a supported Python version, we can safely remove dependencies needed on that version.
|
I have converted the issue to a pull-request and it is now read for review. |
|
I should also note that, the |
|
Excellent, thanks folks! I was just about to make this PR. This causes the release on https://pypi.org/project/llvmlite/ to let |
stuartarchibald
approved these changes
Apr 22, 2020
40 tasks
sklam
added a commit
that referenced
this pull request
Apr 30, 2020
Trove classifiers may be out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/numba/llvmlite/blob/master/setup.py#L181-L183
It should probably read:
3.6 3.7 3.8. I can prep a PR if deemed correct.