Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds override for LLVM version check, re-formats docs. #582

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

stuartarchibald
Copy link
Contributor

Builds on: #581

Adds override for LLVM version check, re-formats docs.

  • Adds environment variable to remove LLVM version check.
  • Reformats install guide doc:
    • 80 char limit
    • Move static linking prose to FAQ
    • Add section on using unsupported LLVMs

* Adds environment variable to remove LLVM version check.
* Reformats install guide doc:
  * 80 char limit
  * Move static linking prose to FAQ
  * Add section on using unsupported LLVMs
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

================================================================================
WARNING * WARNING * WARNING * WARNING * WARNING * WARNING * WARNING * WARNING
================================================================================
The LLVM version check for supported versions has been overridden.
This is unsupported behaviour, llvmlite may not work as intended.
Requested LLVM version: 4.0.1
================================================================================
WARNING * WARNING * WARNING * WARNING * WARNING * WARNING * WARNING * WARNING
================================================================================

Works as intended.

@@ -71,34 +71,46 @@ prebuilt LLVM binary package and skip this step::

The LLVM build process is fully scripted by conda-build_, and the `llvmdev recipe <https://github.com/numba/llvmlite/tree/master/conda-recipes/llvmdev>`_ is the canonical reference for building LLVM for llvmlite. Please use it if at all possible!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this PR, but this line would be wrapped.

@sklam sklam merged commit 7ef21d9 into numba:master Apr 30, 2020
sklam added a commit that referenced this pull request Apr 30, 2020
…n_check

Adds override for LLVM version check, re-formats docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants