-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versioneer to enable Python 3.11 #812
base: main
Are you sure you want to change the base?
Conversation
3bfb690
to
01f5edb
Compare
There is a hack in here to avoid updating the newly copied I think it is related to executing |
01f5edb
to
041641f
Compare
Updated to latest version. |
@oscargus we are starting to prep for 3.11 support slowly. We haven't noticed any failures in our initial testing. Do you have an idea where and why this may break on 3.11 w/o this patch? Thank you! |
I do not really recall anything other than what I stated originally. It uses But if it works, then I guess that there is no immediate point in changing. However, from a quick check it doesn't look like you are testing with 3.11 now (nor any PR?)? Anyway, if you are in that process, I can try to update once again since I think that there is a newer version of versioneer. |
5b7b124
to
b9afd9e
Compare
b9afd9e
to
82d4a02
Compare
OK, we will have to double check.
It was a bit tricky to test with Python 3.11 since Numba/llvmlite are a bit unique in this respect. We have been testing against the RCs for a few months however. The results and information on how we achieved this are here:
Probably a good idea, thank you. |
I checked a bit further and it may be that your version of versioneer is so old so that it doesn't even use Unless of course you want to bump it for other reasons... :-) (Replacing
with
is a possible motivation as well, and I assume that it has developed. But does indeed not seem required.) (I made an effort updating versioneer once I was informed about the issue in a number of relevant packages, although I must admit that I didn't really consider this case.) |
Note that it doesn't state 3.11, but it is the latest available version (0.27) and it doesn't use |
Perhaps then it is better to wait for a 3.11 compat. release? |
Maybe. They just added formal testing for 3.11 python-versioneer/python-versioneer#348 All I can say is that other packages have upgraded and works well. Here is the PR that started it: aesara-devs/aesara#721 You are on 0.12, |
OK, well, if nothing is actually broken broken, then perhaps we could just wait until smth. actually breaks? |
Your call for sure. (I usually update dependencies for the sake of it every now and then, unless it breaks something, but there is of course also the other way around. And this is not really a dependency in the traditional way either.) |
Once we get CI testing for llvmlite for Python 3.11 going I'd suggest to try to update the vendored versioneer code to a Python 3.11 compatible version. Does that make sense? You can subscribe to #885 for updates on when this will happen. |
@oscargus llvmlite 0.40.0 was released already and supports Python 3.11 -- do you want to give this another spin. |
Updated versioneer as old versions of it use
configparser.SafeConfigParser
which is removed in Python 3.11.