Fix symbol resolution race #872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the process of supporting multiple paths for native code loading and allows cleanup to occur on non-windows platforms when the libllvmlite shared library is extracted to a temporary directory.
If two threads attempt to resolve the same symbol at the same time, then both may test the symbol dictionary before the other has a chance to insert a wrapper object, leading to both threads creating their own wrapper. Add double checked locking to avoid this possibility.
|
Note for reviewers: prior discussions on #829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two threads attempt to resolve the same symbol at the same time,
then both may test the symbol dictionary before the other has a chance
to insert a wrapper object, leading to both threads creating their
own wrapper.
Add double checked locking to avoid this possibility.