Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compiler-rt inclusion #909

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

testhound
Copy link

This pull request adds support for including compiler-rt as a artifact. It is meant to address this outstanding issue:
#834

@sklam
Copy link
Member

sklam commented Feb 28, 2023

Developer Note:

This PR depends on merging LLVM14 changes.

@sklam
Copy link
Member

sklam commented Mar 2, 2023

From OOB discussion, the OSX build failure is depending on conda/conda-build#4787 to successfully build compiler-rt

@testhound
Copy link
Author

testhound commented Mar 16, 2023

@sklam and @gmarkall ready for review after adding support for llvm 14. Note that there are several places where I was forced to iinstall llvmdev from my channel because it includes compiler-rt.

For example: "call conda install -y -q --override-channels -c mcollison llvmdev="14.*"

Note that MacOS is still failing due to: conda/conda-build#4787

@testhound
Copy link
Author

@sklam and @gmarkall: all buildfarm tests now pass, ready for review.

@testhound
Copy link
Author

@sklam and @gmarkall I had to modify conda build locally as described by the last comment here:

conda/conda-build#4808

@testhound
Copy link
Author

@sklam and @gmarkall I resolved the merge conflicts and remove support for LLVM 11.

@sklam
Copy link
Member

sklam commented Jun 21, 2023

@esc, please consider this and related PR for inclusion of the upcoming llvmlite release.

@esc esc added this to the v0.41.0 milestone Jun 21, 2023
@esc
Copy link
Member

esc commented Jun 21, 2023

@esc, please consider this and related PR for inclusion of the upcoming llvmlite release.

Thank you, added to the milestone.

@gmarkall gmarkall modified the milestones: v0.41.0rc1, PR Backlog Jul 4, 2023
@esc esc removed this from the PR Backlog milestone Jul 13, 2023
@oliverhu
Copy link

@testhound I followed this PR, and it seems libclang_rt is not statically linked into llvmlite.so, not sure if that is intended or not. btw, shall we add tests to validate this works in both native bfloat architecture & non-native bfloat architecture?

@gmarkall
Copy link
Member

@oliverhu This PR is not being worked on by @testhound anymore, and needs someone to pick it up and continue it - eventually someone working on Numba / llvmlite may get round to it, but it could take some time - do you have any interest in attempting to adopt this PR and working on it? I'm happy whether you are or aren't - just let me know if you are and we can figure out some steps to move this forward.

@oliverhu
Copy link

@gmarkall thanks! happy to help here...the only concern is I'm new to this project (got a crash from tinygrad/tinygrad#1367 so I hunted all the way down here). I might not have the full context besides the issue I was impacted. Is there a channel (slack/discord) to discuss questions? back-n-forth in GitHub is not the most effective way!

@gmarkall
Copy link
Member

@oliverhu There's the Numba Gitter (https://matrix.to/#/#numba_numba:gitter.im) - I'm usually around there during UK office hours (it's 11pm here but I can discuss this interactively tomorrow).

@oliverhu
Copy link

Sounds good, will reach out on gitter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants