Expose TargetLibraryInfo pass #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apmasell
reviewed
May 2, 2023
ffi/targets.cpp
Outdated
| LLVMPassManagerRef PM) { | ||
| unwrap(PM)->add(new TargetLibraryInfoWrapperPass(*unwrap(TLI))); | ||
| API_EXPORT(void) | ||
| LLVMPY_AddTargetLibraryInfoImpl(const char *TripleStr, LLVMPassManagerRef PM) { |
There was a problem hiding this comment.
Why is this Impl? Most of the other passes have Pass as a suffix.
llvmlite/binding/passmanagers.py
Outdated
| @@ -911,6 +914,8 @@ def run_with_remarks(self, function, remarks_format='yaml', | |||
| ffi.lib.LLVMPY_AddSROAPass.argtypes = [ffi.LLVMPassManagerRef] | |||
| ffi.lib.LLVMPY_AddTypeBasedAliasAnalysisPass.argtypes = [ffi.LLVMPassManagerRef] | |||
| ffi.lib.LLVMPY_AddBasicAliasAnalysisPass.argtypes = [ffi.LLVMPassManagerRef] | |||
| ffi.lib.LLVMPY_AddTargetLibraryInfoImpl.argtypes = [c_char_p, | |||
There was a problem hiding this comment.
All of the other pass functions take the pass manager as the first argument. Please swap the arguments to be consistent.
- Rename LLVMPY_AddTargetLibraryInfoImpl to LLVMPY_AddTargetLibraryInfoPass. - Reorder it's arguments to match other similar functions.
apmasell
approved these changes
May 18, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for numba/numba#8898