New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Instruction Namer pass to PassManager #981
Conversation
For some reason that is likely unrelated to the PR, rtd is failing to build |
@tbennun indeed, it seems like there is an issue with a missing configuration file. I will investigate 🕵️ |
According to: https://blog.readthedocs.com/migrate-configuration-v2/ I would say this is part of: Monday, August 14, 2023: Do a second brownout (temporarily enforce this deprecation) for 24 hours: 00:01 PST to 23:59 PST (midnight) So probably OK to just wait and restart the build tomorrow. I will open a ticket that this must be resolved before 25 September. |
|
RTD is building again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test to exercise the pass?
@sklam Added both to the populate passes test and to a specific behavior test |
@tbennun, The test looks good and I have manually confirmed the behavior as well. One last thing, can you add docs for the new pass at |
@sklam of course! I don't know how I missed that. Added. |
Thank you for the contribution! The PR is marked Ready to Merge and its just pending our CI resources to free up since we are in the middle of a release. |
I've added this to the 0.42 milestone, such that it'll be considered for review. |
This PR adds the built-in instruction namer pass to
PassManager
. Theinstnamer
pass is very useful to work with the Python bindings, especially when value names are discarded during compilation andValueRef.name
is empty.