Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NumPy insert #3878

Open
stuartarchibald opened this issue Mar 18, 2019 · 2 comments
Open

Add support for NumPy insert #3878

stuartarchibald opened this issue Mar 18, 2019 · 2 comments
Labels
feature_request good first issue A good issue for a first time contributor

Comments

@stuartarchibald
Copy link
Contributor

Feature request

As title. From https://gitter.im/numba/numba?at=5c8f2a2da21ce51a207b2899.

@stuartarchibald stuartarchibald added feature_request good first issue A good issue for a first time contributor labels Mar 18, 2019
@shimst3r
Copy link

shimst3r commented Feb 23, 2020

Hey @stuartarchibald, I'd like to work on this issue. 😄

Given that I'm fairly new to the numba code base, where exactly is NumPy support implemented? I've found the np directory, but to be honest I'm not sure how to navigate the modules properly.

/Edit: Looking further, I found arrayobj.np_append, so I guess this is the correct place for np_insert?

@stuartarchibald
Copy link
Contributor Author

@shimst3r great, thanks for taking it up. Yes, you are right about the location.

The use of Numba's extension API @overload decorator is strongly recommended for this task. A guide to using @overload is here and API documentation is here.

It may be useful to take a look at examples of pull requests adding support for a NumPy function that have already been done if guidance is needed... here's a couple:

As a new contributor, some instructions for getting set up for development are here and are a great place to start.

If you get stuck/need a hand, the Numba core developers are also available on gitter.im real time chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request good first issue A good issue for a first time contributor
Projects
None yet
Development

No branches or pull requests

2 participants