New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with literally and overloads with inline='always' #5887
Comments
Thanks for the report. Is this the same problem as discussed, where |
Think #5889 should fix. |
@stuartarchibald Thank you for a quick solution, but it solves the problem partly and while the test added is OK, the reproducer it seems still fails (seems _OverloadFunctionTemplate.generic is not called at all). Do you have any thoughts why? |
@kozlov-alexey From the above reproducer using the #5889 PR I get:
I'm not sure what you are expecting to happen, any chance you could expand please? Thanks. |
@stuartarchibald I just didn't get same results at first, but now after cleaning conda env properly it seems sdc tests also pass with this fix. Sorry for confusing. |
@kozlov-alexey no worries, thank you for double checking, glad it is working as expected now. I think the only change we're likely to make subsequent to what's in #5889 at present is to do this #5889 (comment), but I'll check again that the original reproducer is still fixed if that change is made. Thanks for helping to test this! |
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).
Hi,
While trying to migrate to Numba 0.50 we encountered the following problem with literally that may now fail if called from overloads compiled with inline='always'. The error itself looks like this:
And below is the reproducer:
The issue was found on 0.50.0rc1 but still remains in 0.51.0.dev0+56.g92df8df57
It seems it is somehow related to #5673 as it's not observed before it, but please note that even though test from our code base always passes on 0.49.1 the above script which is just simplified version might occasionally fail with 'Repeated literal typing request' as below:
Not sure if this latter is a known issue and wasn't fixed already (please confirm if it's so).
But the main issue is of course new one 'NoneType' object is not callable problem.
Best Regards,
Alexey.
The text was updated successfully, but these errors were encountered: