Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: rename one of the TargetConfig classes #7276

Closed
sklam opened this issue Aug 4, 2021 · 2 comments · Fixed by #7440
Closed

Refactor: rename one of the TargetConfig classes #7276

sklam opened this issue Aug 4, 2021 · 2 comments · Fixed by #7440
Labels
Task
Projects
target overload refactor and cleanup
Milestone
Numba 0.55 RC

Comments

@sklam
Copy link
Member

sklam commented Aug 4, 2021

Rename one of these TargetConfig classes

numba/numba/core/dispatcher.py

Line 28 in 38ab89d

class TargetConfig:

numba/numba/core/targetconfig.py

Line 99 in 38ab89d

class TargetConfig(metaclass=_MetaTargetConfig):

@sklam sklam added the Task label Aug 4, 2021
@sklam sklam added this to Todo in target overload refactor and cleanup via automation Aug 4, 2021
@sklam sklam changed the title Rename one of the TargetConfig classes Refactor: rename one of the TargetConfig classes Aug 4, 2021
@sklam sklam added this to the Numba 0.55 RC milestone Aug 4, 2021
@ankh6
Copy link

ankh6 commented Aug 8, 2021

@sklam Is it still opened ?

@sklam
Copy link
Member Author

sklam commented Aug 10, 2021

This is a maintainer task. See #7150 (comment) for details.

stuartarchibald added a commit to stuartarchibald/numba that referenced this issue Sep 29, 2021
@stuartarchibald
Refactor TargetConfig naming.
792aa8b 
As title.

Closes numba#7276
@stuartarchibald stuartarchibald mentioned this issue Sep 29, 2021
Merged
@stuartarchibald stuartarchibald moved this from Todo to In Progress in target overload refactor and cleanup Sep 29, 2021
target overload refactor and cleanup automation moved this from In Progress to Done Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
target overload refactor and cleanup
Done
Milestone
Numba 0.55 RC
Development

Successfully merging a pull request may close this issue.

Refactor TargetConfig naming. stuartarchibald/numba
2 participants
@sklam @ankh6