Support for out-of-line CFFI modules #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update tests to test with an out-of-line module, and mixing calls to inline and out-of-line functions - Update documentation
| # We have no record of the function's address in an OOL module, so we | ||
| # resort to looking up the function by name in the interpreter's | ||
| # symbol table using ctypes | ||
| cfunc = getattr(ctypes.pythonapi, cffi_func.__name__) |
There was a problem hiding this comment.
This only worked the test is using sin and cos symbols, which are in the "C" namespace. This will not work for other user defined symbols; for example:
from cffi import FFI
ffi = FFI()
ffi.cdef("int foo(int a, int b, int c);")
ffi.set_source("_example",
"""
static int foo(int a, int b, int c)
{
return a + b * c;
}
""")
ffi.compile()
import _example
from numba import cffi_support, njit
cffi_support.register_module(_example)
foo = _example.lib.foo
print(foo(1, 2, 3))
@njit
def bar(x, y, z):
return foo(x, y, z)
print(bar(1, 2, 3))There was a problem hiding this comment.
What you need is:
addr = mod.ffi.addressof(mod.lib, 'foo') # get function pointer
ptr = int(mod.ffi.cast("uintptr_t", addr)) # cast to uintptr_t and then to python int There was a problem hiding this comment.
something like this patch: https://gist.github.com/sklam/7c89e0ec668bc326c92f
There was a problem hiding this comment.
That's a great suggestion, many thanks! Will update the PR and add your example as a test.
|
I've updated this to work with user-defined functions as per your patch, and added a test calling the |
seibert
added a commit
that referenced
this pull request
Oct 5, 2015
Support for out-of-line CFFI modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out-of-line CFFI modules appear differently to inline ones - they are all of type
builtin_function_or_method. This PR allows registering an out-of-line CFFI module with Numba so that it can build a mapping of types for all functions in the module, and therefore compile calls to them in jitted functions.