Support for np.vander #3212
Merged
Support for np.vander #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3212 +/- ##
==========================================
- Coverage 81.11% 81.09% -0.02%
==========================================
Files 386 386
Lines 76398 76518 +120
Branches 8590 8609 +19
==========================================
+ Hits 61967 62055 +88
- Misses 13112 13143 +31
- Partials 1319 1320 +1 |
|
CI looks clean, after a few false starts. |
|
There are a few edge cases where numpy type promotion isn't replicated and / or float precision differences can be observed. I will work on it later this week. |
|
So I think the behaviour is aligned with numpy now, both in terms of type promotion and precision of accumulated values. Let me know what you reckon when you have some time, ta! |
|
Thanks for the patches. This looks good. |
stuartarchibald
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit, submitting for CI.