Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarning about imp module #3237

Merged
merged 2 commits into from Aug 23, 2018
Merged

Fix DeprecationWarning about imp module #3237

merged 2 commits into from Aug 23, 2018

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Aug 19, 2018

In 2013, Python Issue #18192 introduced importlib.util.MAGIC_NUMBER and documented deprecated imp.get_magic() as deprecated

With Python 3.7, DeprecationWarnings are shown again by default.

In 2013, Python Issue #18192 introduced importlib.util.MAGIC_NUMBER and documented deprecated imp.get_magic() as deprecated
@leezu
Copy link
Contributor Author

leezu commented Aug 19, 2018

Note this is only available starting Python 3.4. So this should not be merged before January 1, 2019.

@stuartarchibald
Copy link
Contributor

Thanks for the PR. I've patched this further so that Pythons >= 3.1 use importlib and added a test.

@codecov-io
Copy link

Codecov Report

Merging #3237 into master will decrease coverage by 0.02%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
- Coverage    81.1%   81.07%   -0.03%     
==========================================
  Files         386      386              
  Lines       75721    75884     +163     
  Branches     8491     8522      +31     
==========================================
+ Hits        61411    61525     +114     
- Misses      13009    13051      +42     
- Partials     1301     1308       +7

@seibert
Copy link
Contributor

seibert commented Aug 23, 2018

Looks good. Merging.

@seibert seibert merged commit b08bebd into numba:master Aug 23, 2018
@leezu leezu deleted the patch-1 branch August 25, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants