New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ds_permute types and add tests #3281
Conversation
This fixes the `ds_{,b}permute` intrinsic typing so that only 32bit types can be used in the source, whereas the index lane can be int32 or int64. Tests are added.
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
=========================================
Coverage ? 81.01%
=========================================
Files ? 387
Lines ? 76403
Branches ? 8590
=========================================
Hits ? 61900
Misses ? 13185
Partials ? 1318 |
Looks good. Trying on buildfarm. |
Seems to be failing on ROCm worker due to missing type signatures. Example:
Looks like tests are expecting ds_permute with |
Thanks for pushing it through the build farm. I think the former signature is invalid as that would be a 64bit src, however the latter should be ok, I'll add that. |
Root cause was that |
This needs #3294 before testing else the compiler will fail on lock assertions. |
This fixes the
ds_{,b}permute
intrinsic typing so that only32bit types can be used in the source, whereas the index lane
can be int32 or int64. Tests are added.