Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ds_permute types and add tests #3281

Merged
merged 3 commits into from Sep 9, 2018

Conversation

stuartarchibald
Copy link
Contributor

This fixes the ds_{,b}permute intrinsic typing so that only
32bit types can be used in the source, whereas the index lane
can be int32 or int64. Tests are added.

This fixes the `ds_{,b}permute` intrinsic typing so that only
32bit types can be used in the source, whereas the index lane
can be int32 or int64. Tests are added.
@stuartarchibald stuartarchibald added this to the Numba 0.40 RC milestone Aug 30, 2018
@stuartarchibald stuartarchibald added 3 - Ready for Review Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Aug 30, 2018
@codecov-io
Copy link

codecov-io commented Aug 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@48ea366). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #3281   +/-   ##
=========================================
  Coverage          ?   81.01%           
=========================================
  Files             ?      387           
  Lines             ?    76403           
  Branches          ?     8590           
=========================================
  Hits              ?    61900           
  Misses            ?    13185           
  Partials          ?     1318

@seibert
Copy link
Contributor

seibert commented Sep 4, 2018

Looks good. Trying on buildfarm.

@seibert
Copy link
Contributor

seibert commented Sep 5, 2018

Seems to be failing on ROCm worker due to missing type signatures. Example:

ERROR: test_shuf_device_inclusive_scan (numba.roc.tests.hsapy.test_scan.TestShuffleScan)
----------------------------------------------------------------------
[snip]
    TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Invalid use of Function(<function ds_permute at 0x7fa696933730>) with argument(s) of type(s): (int64, int64)
Known signatures:
 * (int32, int32) -> int32
 * (int64, int32) -> int32
 * (int32, float32) -> float32
 * (int64, float32) -> float32
[snip]

Looks like tests are expecting ds_permute with (int64, int64) and (int64, uint32) signatures.

@stuartarchibald
Copy link
Contributor Author

Thanks for pushing it through the build farm. I think the former signature is invalid as that would be a 64bit src, however the latter should be ok, I'll add that.

@stuartarchibald
Copy link
Contributor Author

Root cause was that scan testing was written for intp moving this to int32 fixes.

@stuartarchibald
Copy link
Contributor Author

This needs #3294 before testing else the compiler will fail on lock assertions.

@seibert seibert added BuildFarm Passed For PRs that have been through the buildfarm and passed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Sep 9, 2018
@seibert seibert merged commit 56065f2 into numba:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review BuildFarm Passed For PRs that have been through the buildfarm and passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants