Permit dtype argument as sole kwarg in np.eye #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title, also reimplements `np.eye` using high level API. Fixes numba#3159
Codecov Report
@@ Coverage Diff @@
## master #3481 +/- ##
==========================================
+ Coverage 80.62% 80.63% +<.01%
==========================================
Files 390 390
Lines 79044 79039 -5
Branches 8956 8957 +1
==========================================
- Hits 63732 63730 -2
+ Misses 13908 13907 -1
+ Partials 1404 1402 -2 |
|
This looks good. Also like that it moves over to the high level API and shrinks the codebase! (Only by 16 lines, but every bit counts...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, also reimplements
np.eyeusing high level API.Fixes #3159