Document string support #3506
Merged
Document string support #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3506 +/- ##
==========================================
+ Coverage 80.62% 80.69% +0.06%
==========================================
Files 392 392
Lines 79770 80130 +360
Branches 9063 9117 +54
==========================================
+ Hits 64317 64663 +346
- Misses 14038 14051 +13
- Partials 1415 1416 +1 |
Co-Authored-By: seibert <stan@mtrr.org>
Co-Authored-By: seibert <stan@mtrr.org>
|
OK, I have accepted the proposed change. |
seibert
added
4 - Waiting on reviewer
|
hmmm, that edit functionality on github doesn't line wrap or deal with white space, guess that's expected, so apologies, this needs manual fixing now. The change renders ok as HTML (apart from a space before the full stop), but the source lines overrun. Perhaps edit manually?! Guess we've learned not to do that again for RST. |
stuartarchibald
added
4 - Waiting on author
stuartarchibald
approved these changes
Nov 19, 2018
seibert
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for preliminary string support