Fix example and docs typos for objmode context manager.
#3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title. Fixes numba#3575
Codecov Report
@@ Coverage Diff @@
## master #3577 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 393 393
Lines 80425 80425
Branches 9160 9160
=======================================
Hits 64896 64896
Misses 14109 14109
Partials 1420 1420 |
sklam
reviewed
Dec 10, 2018
numba/withcontexts.py
Outdated
|
|
||
| @njit | ||
| def foo(): | ||
| x = np.arange(5) | ||
| y = np.arange(5) |
There was a problem hiding this comment.
We should change it so that we allocate y = np.zeros_like(x) and leave x as is. We want to show that input arrays do not need to be annotated.
There was a problem hiding this comment.
Ah yes, thanks, fixed in eacd307
sklam
reviewed
Dec 10, 2018
numba/withcontexts.py
Outdated
| with objmode(y='intp[:]'): # annotate return type | ||
| # this region is executed by object-mode. | ||
| y += bar(x) | ||
| y += bar(y) |
There was a problem hiding this comment.
fixed in eacd307
|
Thanks for the review. I also note that |
Implement @sklam's suggestions.
seibert
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Fixes #3575