Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some simplication to lowering #3607

Merged
merged 5 commits into from
Jan 8, 2019
Merged

Some simplication to lowering #3607

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24e0c6c
PEP8
sklam Dec 14, 2018
acde6c3
Refactor lower_call
sklam Dec 14, 2018
d8a7703
Get rid of NumbaFunction
sklam Dec 14, 2018
0c18e9f
Get rid of codegen.add_linking_library.
sklam Dec 17, 2018
ee16aba
Apply suggestion in code review
sklam Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ exclude =
numba/pylowering.py
numba/io_support.py
numba/parfor.py
numba/lowering.py
numba/numba_entry.py
numba/stencilparfor.py
numba/numpy_support.py
Expand Down
1 change: 0 additions & 1 deletion numba/datamodel/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ def __init__(self, dmm, fe_type):
@register_default(types.Dummy)
@register_default(types.ExceptionInstance)
@register_default(types.ExternalFunction)
@register_default(types.NumbaFunction)
@register_default(types.Macro)
@register_default(types.EnumClass)
@register_default(types.IntEnumClass)
Expand Down
5 changes: 3 additions & 2 deletions numba/jitclass/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,9 @@ def _add_linking_libs(context, call):
"""
Add the required libs for the callable to allow inlining.
"""
for lib in getattr(call, "libs", ()):
context.active_code_library.add_linking_library(lib)
libs = getattr(call, "libs", ())
if libs:
context.add_linking_libs(libs)


def register_class_type(cls, spec, class_ctor, builder):
Expand Down