New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
np.where with broadcasting #3630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3630 +/- ##
========================================
Coverage ? 80.5%
========================================
Files ? 395
Lines ? 81117
Branches ? 9234
========================================
Hits ? 65300
Misses ? 14389
Partials ? 1428 |
Hi, let me know what you think of this relatively simple extension. Could arguably be taken further either in this PR or subsequently; might have incremental utility on its own. |
Thanks for the patches. Am I right in thinking that this is with view of closing #3339 ? |
I hadn't spotted that one to be honest, but it should fit the bill. It was more of a thought experiment which turned into a PR :) |
This is pending update RE #3650 |
The last commit should extend support to cover some basic use cases. Let me know what you think, ta! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, adding support for these additional cases is really useful. Looks good to merge.
Small extension to
np.where
to support use cases like:Initial commit for CI.