Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves issue #3528. Adds support for slices when not using parallel=True. #3719

Merged
merged 6 commits into from May 1, 2019
Merged

Resolves issue #3528. Adds support for slices when not using parallel=True. #3719

merged 6 commits into from May 1, 2019

Conversation

DrTodd13
Copy link
Collaborator

The pyStencil version is still failing. I think Stuart should take a look at this one.

@DrTodd13 DrTodd13 changed the title Resolves issue3528. Adds support for slices when not using parallel=True. Resolves issue #3528. Adds support for slices when not using parallel=True. Jan 29, 2019
@DrTodd13 DrTodd13 changed the title Resolves issue #3528. Adds support for slices when not using parallel=True. [WIP] Resolves issue #3528. Adds support for slices when not using parallel=True. Jan 29, 2019
@DrTodd13 DrTodd13 changed the title [WIP] Resolves issue #3528. Adds support for slices when not using parallel=True. Resolves issue #3528. Adds support for slices when not using parallel=True. Jan 31, 2019
@sklam sklam added this to Need Review in Active Feb 4, 2019
@stuartarchibald stuartarchibald mentioned this pull request Apr 3, 2019
Closed
sklam
sklam reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor issues.

numba/tests/test_stencils.py Outdated Show resolved Hide resolved
numba/tests/test_stencils.py Outdated Show resolved Hide resolved
numba/tests/test_stencils.py Outdated Show resolved Hide resolved
numba/tests/test_stencils.py Outdated Show resolved Hide resolved
@stuartarchibald stuartarchibald mentioned this pull request Apr 18, 2019
Merged
@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Apr 18, 2019
@stuartarchibald
Copy link
Contributor

Thanks for the review @sklam, I think 5dbca1f addresses all your comments.

@stuartarchibald stuartarchibald removed the 4 - Waiting on author Waiting for author to respond to review label Apr 18, 2019
@stuartarchibald stuartarchibald added the 4 - Waiting on reviewer Waiting for reviewer to respond to author label Apr 18, 2019
@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Apr 25, 2019
@stuartarchibald stuartarchibald changed the base branch from master to master_30_april_2019 April 30, 2019 08:27
@stuartarchibald stuartarchibald changed the base branch from master_30_april_2019 to master April 30, 2019 08:28
@seibert seibert merged commit 54310f0 into numba:master May 1, 2019
Active automation moved this from Need Review to Done May 1, 2019
@DrTodd13 DrTodd13 deleted the issue3528 branch June 25, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald left review comments

@sklam sklam sklam approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
Active
Done
Milestone
Numba 0.44 RC
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DrTodd13 @stuartarchibald @sklam @seibert