Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array.sum(axis) 1d input return type. #3816

Merged
merged 1 commit into from Mar 4, 2019
Merged

Fix array.sum(axis) 1d input return type. #3816

merged 1 commit into from Mar 4, 2019

Conversation

stuartarchibald
Copy link
Contributor

Makes it such that if a summation with an axis is called on
a 1d array the return type is scalar.

Fixes #3815

@stuartarchibald
Fix array.sum(axis) 1d input return type.
415cf75 
Makes it such that if a summation with an axis is called on
a 1d array the return type is scalar.

Fixes numba#3815
@seibert
Copy link
Contributor

seibert commented Feb 28, 2019

looks good, pending CI passing

@seibert seibert added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Mar 1, 2019
@stuartarchibald
Copy link
Contributor Author

Thanks for the review. CI passed, merging.

@stuartarchibald stuartarchibald added this to the Numba 0.43 RC milestone Mar 4, 2019
@stuartarchibald stuartarchibald merged commit a2ef2ea into numba:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.43 RC
Development

Successfully merging this pull request may close these issues.

Sum with axis argument on 1d array returns array instead of skalar
2 participants
@stuartarchibald @seibert