Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumPy 1.16 support #3826

Merged
merged 14 commits into from Mar 21, 2019
Merged

NumPy 1.16 support #3826

merged 14 commits into from Mar 21, 2019

Conversation

stuartarchibald
Copy link
Contributor

As title.

Closes #3741

@stuartarchibald
NumPy 1.16 support
1682399 
As title.

Closes numba#3741
@stuartarchibald stuartarchibald added this to the Numba 0.43 RC milestone Mar 4, 2019
@seibert seibert mentioned this pull request Mar 5, 2019
Closed
22 tasks
@stuartarchibald stuartarchibald mentioned this pull request Mar 6, 2019
Merged
@stuartarchibald stuartarchibald mentioned this pull request Mar 8, 2019
Closed
@rjenc29
Copy link
Contributor

rjenc29 commented Mar 10, 2019

Morning, I'll have a look at refactoring np.interp - in the meantime, this crude feature gate will make it line up with numpy across versions, I think:
https://gist.github.com/rjenc29/3d3e70693f2fe68be1cf315d3d3a5092

I've tested locally on a couple of pre- and post-1.16 versions and it seems OK - so just thought I would flag it in case useful.

@sklam sklam added this to In Progress in Active Mar 14, 2019
sklam
sklam reviewed Mar 20, 2019
View reviewed changes
numba/targets/arraymath.py Outdated
# has dtype, but is not something understandable
if 'cannot be represented' in str(e) or \
'data type not understood' in str(e):
obj = obj.dtype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only sensible type for obj is Sequence. Better to explicitly check for that then to rely on exception messages.

@sklam
Copy link
Member

sklam commented Mar 20, 2019

The rest looks good. Just pending CI.

@stuartarchibald
Merge remote-tracking branch 'upstream/master' into wip/np116
fdf4f64 
Resolved Conflicts:
	docs/source/reference/numpysupported.rst
	numba/tests/test_np_functions.py
@stuartarchibald
Reenable interp 1.16 tests
95970ce
@stuartarchibald
Copy link
Contributor Author

I've merged in master to resolve conflicts and also reenabled some more skipped np 116 tests.

@stuartarchibald
Copy link
Contributor Author

stuartarchibald commented Mar 21, 2019 •
edited

Pending CI pass I think this can be merged.

@seibert seibert mentioned this pull request Mar 21, 2019
Closed
11 tasks
@seibert
Copy link
Contributor

seibert commented Mar 21, 2019

CI looks good.

@seibert seibert added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Mar 21, 2019
@stuartarchibald stuartarchibald merged commit 80d82b0 into numba:master Mar 21, 2019
Active automation moved this from In Progress to Done Mar 21, 2019
@hmaarrfk hmaarrfk mentioned this pull request May 5, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam left review comments

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
Active
Done
Milestone
Numba 0.43.1 RC
Development

Successfully merging this pull request may close these issues.

Add support for Numpy 1.16
4 participants
@stuartarchibald @rjenc29 @sklam @seibert