Unicode type iteration #3842
Merged
Unicode type iteration #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the unicode type iterable and also fixes up a selection of other things that were causing minor issues on the way. Not limited to: * Contractual clarity over reference ownership in `iternext_impl` * Matching debug print with function names in C code * PEP8
As title.
|
Is the reference ownership issue such that it makes sense to be explicit about |
|
RE:#3842 (comment) It could be, wonder if new, borrowed and untracked all ought to be quantified and specification required? |
seibert
requested changes
Mar 8, 2019
As title.
seibert
approved these changes
Mar 8, 2019
|
@seibert what do you think of stuartarchibald@83ae051?diff=unified ? |
|
I think that is a good change. Most booleans turn into enums anyway. :) |
stuartarchibald
added
4 - Waiting on reviewer
|
Need to merge master into this PR and fix the dictionary usage of |
|
This is ready for re-review, dictionaries are fixed up. |
|
Looks good. Ready to merge. |
seibert
added
5 - Ready to merge
|
Are the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the unicode type iterable and also fixes up a selection
of other things that were causing minor issues on the way. Not
limited to:
iternext_impl