Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfail ediff1d test on windows + np1.16 #3903

Merged
merged 2 commits into from
Mar 26, 2019
Merged

xfail ediff1d test on windows + np1.16 #3903

merged 2 commits into from
Mar 26, 2019

Conversation

sklam
Copy link
Member

@sklam sklam commented Mar 26, 2019

(see #3898)

  • Merging into release0.43.1 branch directly.

@sklam sklam added the Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm label Mar 26, 2019
@sklam sklam added BuildFarm Passed For PRs that have been through the buildfarm and passed 3 - Ready for Review and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Mar 26, 2019
@sklam
Copy link
Member Author

sklam commented Mar 26, 2019

i've manually tested it on buildfarm

@stuartarchibald
Copy link
Contributor

Looks good, thanks for the patch,

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Mar 26, 2019
@sklam sklam merged commit 8dabe7a into numba:release0.43.1 Mar 26, 2019
@sklam sklam deleted the fix/xfail_ediff1d_tests branch March 26, 2019 18:59
sklam added a commit to sklam/numba that referenced this pull request Mar 26, 2019
@sklam
Merge pull request numba#3903 from sklam/fix/xfail_ediff1d_tests
d29a55d 
xfail ediff1d test on windows + np1.16
stuartarchibald added a commit that referenced this pull request Apr 1, 2019
@stuartarchibald
Merge pull request #3905 from sklam/fix/ediff_xfail_cherry
a015600 
Cherrypick #3903 to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sklam @stuartarchibald