Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds .nbytes property to CUDA device array objects. #3933

Merged
merged 4 commits into from Apr 22, 2019
Merged

Adds .nbytes property to CUDA device array objects. #3933

merged 4 commits into from Apr 22, 2019

Conversation

quasiben
Copy link
Contributor

@quasiben quasiben commented Apr 2, 2019

Adding a property to device objects to return the size (in bytes) of the array

closes #3810

@stuartarchibald stuartarchibald added CUDA CUDA related issue/PR 3 - Ready for Review Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Apr 3, 2019
@stuartarchibald stuartarchibald added this to the Numba 0.44 RC milestone Apr 3, 2019
@stuartarchibald stuartarchibald changed the title fea/nbytes Adds .bytes property to CUDA device array objects. Apr 5, 2019
stuartarchibald
stuartarchibald reviewed Apr 8, 2019
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. As this is a CUDA change it will require a round trip through the Numba build farm to test it on real hardware which may cause a bit of delay, apologies.

numba/cuda/cudadrv/devicearray.py Outdated Show resolved Hide resolved
numba/cuda/cudadrv/devicearray.py Show resolved Hide resolved
@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Apr 8, 2019
@quasiben
Copy link
Contributor Author

@sklam @stuartarchibald thanks for the comments. I made necessary changes. When you have time can you review again ?

@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels Apr 19, 2019
@quasiben quasiben changed the title Adds .bytes property to CUDA device array objects. Adds .nbytes property to CUDA device array objects. Apr 19, 2019
@seibert
Copy link
Contributor

seibert commented Apr 19, 2019

Running this through the CUDA systems in our buildfarm, and then this will be ready to merge.

@seibert seibert added 5 - Ready to merge Review and testing done, is ready to merge and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Apr 19, 2019
@seibert
Copy link
Contributor

seibert commented Apr 19, 2019

Looks good! Thanks!

@sklam sklam added this to Ready to Merge in Active Apr 22, 2019
@sklam sklam merged commit 4f8ab34 into numba:master Apr 22, 2019
Active automation moved this from Ready to Merge to Done Apr 22, 2019
@quasiben quasiben mentioned this pull request Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald left review comments

@sklam sklam sklam left review comments

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge CUDA CUDA related issue/PR
Projects
Active
Done
Milestone
Numba 0.44 RC
Development

Successfully merging this pull request may close these issues.

Implement bytes on DeviceNDArray
4 participants
@quasiben @seibert @stuartarchibald @sklam