Isolate mutation on func_ir._definitions #3940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is failing on py27 due to ChainMap usage. Once we get rid of |
|
how should transformations that change definitions as they go work? |
|
Now that the definition-changing code is isolated, I think we can pull |
|
If code transformation should fail, the func_ir state is still self-consistent. |
|
This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks! |
github-actions
bot
added
the
abandoned - stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. DO NOT MERGE
This is a refactor on the
func_ir._definitionsattribute usage.•
._definitionsis now immutable and autogenerated from the IR so it is never out-of-sync.• a new
.temp_definitionsis added to find places that does temporary mutation on it (like in array_analysis.py and inline_closurecall.py). These temporary mutations are not yet visible in the IR, yet. (TODO: refactor these mutations so we get remove.temp_definitions.