Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IR comparable and legalize it. #4162

Merged
merged 6 commits into from Aug 13, 2019
Merged

Make IR comparable and legalize it. #4162

merged 6 commits into from Aug 13, 2019

Conversation

stuartarchibald
Copy link
Contributor

Adds:

  • Loose comparison for IR nodes and FunctionIR.
  • IR legalization call just prior to lowering.
  • Some simple differential diagnostics on the legalized IR.

@stuartarchibald
Make IR comparable and legalize it.
17b18f6 
Adds:

 * Loose comparison for IR nodes and FunctionIR.
 * IR legalization call just prior to lowering.
 * Some simple differential diagnostics on the legalized IR.
@stuartarchibald stuartarchibald added this to the Numba 0.45 RC milestone Jun 11, 2019
@stuartarchibald
Copy link
Contributor Author

Note for reviewers. I made some decisions about equality, they aren't set in stone, this is simply a start.

sklam
sklam reviewed Jun 14, 2019
View reviewed changes
numba/ir.py Outdated Show resolved Hide resolved
sklam
sklam reviewed Jun 14, 2019
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I identified some minor static issues so far. I'll be looking into the behavior next.

numba/ir.py Outdated Show resolved Hide resolved
numba/ir.py

def __eq__(self, other):
if type(self) == type(other):
for name in self.__slots__:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will not support inheritance. An instance's __slots__ can only see the version defined in its type but not it's parent's.

numba/ir.py Outdated Show resolved Hide resolved
numba/ir.py Outdated Show resolved Hide resolved
numba/ir.py Outdated Show resolved Hide resolved
numba/six.py Outdated Show resolved Hide resolved
sklam
sklam reviewed Jun 14, 2019
View reviewed changes
numba/ir.py Outdated Show resolved Hide resolved
@sklam sklam added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Jun 21, 2019
@seibert seibert modified the milestones: Numba 0.45 RC, Numba 0.46 RC Jul 2, 2019
@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels Jul 10, 2019
sklam
sklam approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Forgot to re-review this PR. This is ready to merge now.

@sklam sklam added the 5 - Ready to merge Review and testing done, is ready to merge label Aug 8, 2019
@stuartarchibald stuartarchibald removed the 4 - Waiting on reviewer Waiting for reviewer to respond to author label Aug 12, 2019
@stuartarchibald stuartarchibald merged commit a1b4bf9 into numba:master Aug 13, 2019
@stuartarchibald stuartarchibald mentioned this pull request Oct 11, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.46 RC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuartarchibald @sklam @seibert