Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dtype input argument in np.sum #4472

Merged
merged 29 commits into from
Sep 30, 2019
Merged

Allow dtype input argument in np.sum #4472

merged 29 commits into from
Sep 30, 2019

Commits on Aug 21, 2019

  1. added dtype kwarg (doesn't do anything) + tests

    @luk-f-a
    luk-f-a committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    9e5f6b7 View commit details
    Browse the repository at this point in the history

  2. fixed impl - basic implementation passes tests

    @luk-f-a
    luk-f-a committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    cf899bf View commit details
    Browse the repository at this point in the history

  3. format fixes and test removal

    @luk-f-a
    luk-f-a committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    de3d1c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. added dtype-axis combination

    @luk-f-a
    luk-f-a committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    ee11c3d View commit details
    Browse the repository at this point in the history

  2. added dtype-axis tests

    @luk-f-a
    luk-f-a committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    4d674fa View commit details
    Browse the repository at this point in the history

  3. adjusting arraydecl (1 of 2)

    @luk-f-a
    luk-f-a committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    bbde75f View commit details
    Browse the repository at this point in the history

  4. adjusting arraydecl (2 of 2)

    @luk-f-a
    luk-f-a committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    66d525c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. flake8 fixes

    @luk-f-a
    luk-f-a committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    bd5014a View commit details
    Browse the repository at this point in the history

  2. factoring out common parts of sum implementations 

    (with and without dtype arg)
    @luk-f-a
    luk-f-a committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    7c3d9bb View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2019

  1. added tests

    @luk-f-a
    luk-f-a committed Aug 31, 2019
    Configuration menu
    Copy the full SHA
    3abb4a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. fixed issue with np.int32 arrays

    @luk-f-a
    luk-f-a committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    496eeca View commit details
    Browse the repository at this point in the history

  2. disabled timedelta test

    @luk-f-a
    luk-f-a committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    affa1ec View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2019

  1. flake8 fix

    @luk-f-a
    luk-f-a committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    b63d8d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. updated documentation

    @luk-f-a
    luk-f-a committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    5a3e219 View commit details
    Browse the repository at this point in the history

  2. split out tests for int32 and uint32 due to special numpy behaviour

    @luk-f-a
    luk-f-a committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    e0370f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into sum_with_dtype 

    # Conflicts:
#	docs/source/reference/numpysupported.rst
    @luk-f-a
    luk-f-a committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    bebddf2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into sum_with_dtype 

    # Conflicts:
#	docs/source/reference/numpysupported.rst
    @luk-f-a
    luk-f-a committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    26ab11f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. test fix for 32-bit machines

    @luk-f-a
    luk-f-a committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    d236a98 View commit details
    Browse the repository at this point in the history

  2. fix for scalar results

    @luk-f-a
    luk-f-a committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    0ffe381 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. fixes to address review

    @luk-f-a
    luk-f-a committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    18be7fb View commit details
    Browse the repository at this point in the history

  2. fix docs char limit

    @luk-f-a
    luk-f-a committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    8959801 View commit details
    Browse the repository at this point in the history

  3. changes after second review

    @luk-f-a
    luk-f-a committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    c25d0b5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. removing redundant tests

    @luk-f-a
    luk-f-a committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    0726ed1 View commit details
    Browse the repository at this point in the history

  2. Word wrap docs 

    As title
    @stuartarchibald
    stuartarchibald committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    50ac590 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from stuartarchibald/pr_4472 

    Word wrap docs
    @luk-f-a
    luk-f-a committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    f3a333b View commit details
    Browse the repository at this point in the history

  4. removing redundant tests

    @luk-f-a
    luk-f-a committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    6bc30ed View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/sum_with_dtype' into sum_with_dtype

    @luk-f-a
    luk-f-a committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    0d642a9 View commit details
    Browse the repository at this point in the history

  6. reverting addition of mean tests

    @luk-f-a
    luk-f-a committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    80feaa6 View commit details
    Browse the repository at this point in the history

  7. reverting addition of mean tests2

    @luk-f-a
    luk-f-a committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    a3074b4 View commit details
    Browse the repository at this point in the history