Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liveness for remove dead of parfors (and other IR extensions) #4474

Merged
merged 3 commits into from Aug 29, 2019

Conversation

ehsantn
Copy link
Collaborator

@ehsantn ehsantn commented Aug 21, 2019

No description provided.

@ehsantn ehsantn changed the title [WIP] Fix liveness for remove dead of parfors (and other IR extensions) Fix liveness for remove dead of parfors (and other IR extensions) Aug 21, 2019
@sklam
Copy link
Member

sklam commented Aug 21, 2019

The error from test_alias_parfor_extension without the fix in ir_utils.py looks very much like the kind of errors I am seeing in my SSA attempt. And it would make sense because SSA will create many aliases as new versions of a variable is created.

@ehsantn
Copy link
Collaborator Author

ehsantn commented Aug 21, 2019

Makes sense. One potentially related issue might be copy propagation not fully working since SSA generates extra assignments.

@sklam
Copy link
Member

sklam commented Aug 22, 2019

The test is failing on windows and 32-bit linux. It needs a skip test.

@ehsantn
Copy link
Collaborator Author

ehsantn commented Aug 22, 2019

done.

@stuartarchibald
Copy link
Contributor

Thanks for the patch. I've checked this manually and I'm of the view that the fix makes sense.

@sklam I recommend merge unless you have any other thoughts related to SSA?

@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review labels Aug 27, 2019
@sklam
Copy link
Member

sklam commented Aug 27, 2019

This is good for merging. I've checked this against my SSA branch. It fixes less tests then I have hoped.

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Aug 27, 2019
@seibert seibert merged commit fee9b90 into numba:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants