Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reimplementing np.mean with overload and adding axis parameter #4480

Closed
wants to merge 26 commits into from

Conversation

luk-f-a
Copy link
Contributor

@luk-f-a luk-f-a commented Aug 23, 2019

Partially addresses #1269 and #4245
Requires #4472 (first 3 commits come from that PR), #5060 and #5711, which fix intermediate problems.

@luk-f-a
Copy link
Contributor Author

luk-f-a commented Aug 27, 2019

closing to open a new branch to avoid merge conflicts with #4472

@luk-f-a luk-f-a deleted the mean_axis_overload branch August 27, 2019 19:35
@luk-f-a luk-f-a reopened this Oct 1, 2019
numba/targets/arraymath.py Outdated Show resolved Hide resolved
luk-f-a and others added 3 commits October 11, 2019 15:55
@luk-f-a
Copy link
Contributor Author

luk-f-a commented Nov 5, 2019

Status: The current mean is able to deal with np.datetime64 but an overload-based version fails because of #4540. It was agreed with @stuartarchibald that breaking support for np.datetime64 would be wrong, so this PR is on hold until that issue is resolved.

@stuartarchibald stuartarchibald added this to the PR Backlog milestone May 14, 2020
# Conflicts:
#	numba/np/numpy_support.py
@luk-f-a luk-f-a marked this pull request as draft May 16, 2020 15:14
@luk-f-a
Copy link
Contributor Author

luk-f-a commented May 16, 2020

current status: #5060 is almost done and will fix #4540 which was blocking this PR.
However, another issue came up: timedelta could not be divided by a number, which is needed to calculate the mean. So I fixed that in #5711. However, that's not the end of it, there's an additional issue: after changing the implementation from lower_builtin to overload the new function is not registered in npydecl.registry. This is a problem for ir_utils.get_np_ufunc_typ, which looks for the function there, leading to a failure in the tests test_parfor.test_var and test_parfor.test_std

@N720720
Copy link

N720720 commented Mar 13, 2021

It looks like we are so close to get this working. How can we register the new function in npydecl.registry? How to contribute to this issue?

# Conflicts:
#	numba/core/typing/npydecl.py
@sklam
Copy link
Member

sklam commented Jul 8, 2022

I pushed a merge main commit to resolve conflict so we get new CI run. There are changes to get_np_ufunc_typ that may change things.

@github-actions
Copy link

github-actions bot commented May 9, 2023

This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks!

@github-actions github-actions bot added the stale Marker label for stale issues. label May 9, 2023
@github-actions github-actions bot added the abandoned - stale PRs automatically closed due to stale status label May 16, 2023
@github-actions github-actions bot closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress abandoned - stale PRs automatically closed due to stale status stale Marker label for stale issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants