Make numba.dummyarray.Array iterable #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready for review btw. |
|
@sklam please could you have a look at this, thanks. |
|
This looks reasonable, and fixes the getitem implementation to properly raise IndexError (which it wasn't before). |
seibert
added
5 - Ready to merge
|
This needs a CUDA smoke test. The dummyarray is used a lot there. |
sklam
added
Pending BuildFarm
|
Thanks everyone! |
leofang
added a commit
to leofang/mpi4py
that referenced
this pull request
Jan 2, 2020
This command works with Open MPI 4.0.1 (compiled with the --with-cuda flag):
python test/runtests.py --numba --no-thread -v
The implementation is a minimum requirement for circumventing many Numba bugs,
which is unfortunate. Even so, we still need Numba 0.46 + the two patches from
numba/numba#4629 and numba/numba#5012 to make it fully work.
TODO: figure out the minimum supported Numba version and error out when the
installed version is lower than that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4201. @sklam we need this and #4609 to test Numba device arrays in mpi4py, so I went ahead and fixed it myself. Please take a look. (It doesn't have to be included in 0.46RC, so no rush.)
Thanks!