Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cuda array interface to version 2 #4675

Merged
merged 4 commits into from Oct 9, 2019
Merged

Bump cuda array interface to version 2 #4675

merged 4 commits into from Oct 9, 2019

Conversation

sklam
Copy link
Member

@sklam sklam commented Oct 8, 2019

#4609 bumped the cuda_array_interface version to 2 in the docs but not in the code.
This bumps the version and added an extra test to check that unnecessary non-None strides still works.

@sklam sklam added 3 - Ready for Review CUDA CUDA related issue/PR labels Oct 8, 2019
@seibert
Copy link
Contributor

seibert commented Oct 8, 2019

Looks good. Ready to merge once CUDA smoke test passes.

@seibert seibert added the Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm label Oct 8, 2019
@jakirkham
Copy link
Contributor

Maybe we should start listing the current version in this doc?

@seibert
Copy link
Contributor

seibert commented Oct 8, 2019

The current description of the version attribute says "An integer for the version of the interface being exported. The current version is 2.". Are you suggesting we make that more prominent?

@jakirkham
Copy link
Contributor

Ah I see that now. Yeah it would be nice if it were in the title (like "CUDA Array Interface (version 2)").

@seibert
Copy link
Contributor

seibert commented Oct 8, 2019

Makes sense. @sklam: can you make that change?

@sklam sklam changed the title Bump cuda array interface version Bump cuda array interface to version 2 Oct 8, 2019
@seibert
Copy link
Contributor

seibert commented Oct 9, 2019

Smoke test looks good.

@seibert seibert added BuildFarm Passed For PRs that have been through the buildfarm and passed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Oct 9, 2019
@jakirkham
Copy link
Contributor

Sorry I meant adding the version to this doc page’s title?

@sklam
Copy link
Member Author

sklam commented Oct 9, 2019

Heh, I only noticed you were referring to the doc title after I changed the PR title. But then I decided to wait until the morning as my brain is clearly not fully functional.

Anyway, it's updated now.

@seibert seibert added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Oct 9, 2019
@seibert
Copy link
Contributor

seibert commented Oct 9, 2019

OK, don't need to wait for CI to finish. This is ready to merge (and to cherry pick onto release branch).

@seibert seibert mentioned this pull request Oct 9, 2019
Closed
18 tasks
@sklam sklam mentioned this pull request Oct 9, 2019
Merged
@jakirkham
Copy link
Contributor

Thanks @sklam! 😄

@leofang
Copy link
Contributor

leofang commented Oct 9, 2019

Oh boy, how come I missed that! Thanks for the followup @sklam.

@sklam sklam merged commit 02188e5 into numba:master Oct 9, 2019
sklam added a commit that referenced this pull request Oct 9, 2019
@sklam
Merge pull request #4680 from sklam/fix/cuda_array_face
50151e1 
Apply #4675 to on 0.46 release branch
@sklam sklam deleted the fix/cuda_array_face branch October 9, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sklam @seibert @jakirkham @leofang