Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires llvmlite >=0.30.0 #4725

Merged
merged 2 commits into from Oct 23, 2019
Merged

Requires llvmlite >=0.30.0 #4725

merged 2 commits into from Oct 23, 2019

Conversation

marcelotrevisani
Copy link
Contributor

stuartarchibald
stuartarchibald reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, seems like this would be a good thing to declare. There's one tiny stylistic suggestion to resolve and then this is good to go. Thanks again!

README.rst Outdated Show resolved Hide resolved
@stuartarchibald stuartarchibald added this to the Numba 0.47 RC milestone Oct 21, 2019
@stuartarchibald stuartarchibald added the 4 - Waiting on author Waiting for author to respond to review label Oct 21, 2019
@marcelotrevisani @stuartarchibald
Update README.rst
32bad83 
Co-Authored-By: stuartarchibald <stuartarchibald@users.noreply.github.com>
stuartarchibald
stuartarchibald approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review labels Oct 21, 2019
@seibert seibert merged commit 57854f1 into numba:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.47 RC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcelotrevisani @stuartarchibald @seibert