Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic support for try except #4902

Merged
merged 51 commits into from
Dec 12, 2019
Merged

basic support for try except #4902

merged 51 commits into from
Dec 12, 2019

Commits on Nov 20, 2019

  1. Add bytecode support for simple try/except for the catch all case.

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    440f8d7 View commit details
    Browse the repository at this point in the history

  2. Fix stack adjustment for setup except/finally

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    8c4d8b6 View commit details
    Browse the repository at this point in the history

  3. Make each bytecode statement branch and check for exception raised

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    b39d31f View commit details
    Browse the repository at this point in the history

  4. Minimal support for raise and catch

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    28fb37f View commit details
    Browse the repository at this point in the history

  5. Check whether we are in a try block at runtime

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    92e25ed View commit details
    Browse the repository at this point in the history

  6. Proper cleanup of try-block

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    9bc4f53 View commit details
    Browse the repository at this point in the history

  7. Add tests

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    b15e371 View commit details
    Browse the repository at this point in the history

  8. Support nested try

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    c342569 View commit details
    Browse the repository at this point in the history

  9. More testing

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    419609f View commit details
    Browse the repository at this point in the history

  10. Add test with loops

    @sklam
    sklam committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    0b9147d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Add TryRaise and StaticTryRaise IR node to handle statements that 

    raise exception inside a try-block
    @sklam
    sklam committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    5eba76b View commit details
    Browse the repository at this point in the history

  2. STASH

    @sklam
    sklam committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    0ccad8d View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Stronger typing for block kinds

    @sklam
    sklam committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    7c26ec0 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Working on exception catching

    @sklam
    sklam committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    3594865 View commit details
    Browse the repository at this point in the history

  2. Support catching exactly Exception classes

    @sklam
    sklam committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    5f188e6 View commit details
    Browse the repository at this point in the history

  3. Fix withlifting

    @sklam
    sklam committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    ca5548d View commit details
    Browse the repository at this point in the history

  4. Fix loop break

    @sklam
    sklam committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    9b2b035 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Fix test failure due to unsupported try-except

    @sklam
    sklam committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c8b5686 View commit details
    Browse the repository at this point in the history

  2. Add test for nested try-except-finally

    @sklam
    sklam committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    f2e4a72 View commit details
    Browse the repository at this point in the history

  3. Remove old try-except test in test_flow_control.py 

    New tests in test_try_except.py
    @sklam
    sklam committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    a118a7c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Test try except with refcounted types

    @sklam
    sklam committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    bee41ca View commit details
    Browse the repository at this point in the history

  2. Test try-except in generator and with-objmode

    @sklam
    sklam committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    a239196 View commit details
    Browse the repository at this point in the history

  3. Test try-except with parfors

    @sklam
    sklam committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    9e7eb24 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Add more skips

    @sklam
    sklam committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    d7d8489 View commit details
    Browse the repository at this point in the history

  2. Cleaning up and docstrings

    @sklam
    sklam committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    a86e756 View commit details
    Browse the repository at this point in the history

  3. Skip test

    @sklam
    sklam committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    359d1b7 View commit details
    Browse the repository at this point in the history

  4. More cleanup

    @sklam
    sklam committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    a5e355e View commit details
    Browse the repository at this point in the history

  5. Remove local import

    @sklam
    sklam committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    ce77574 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. some more tests

    @stuartarchibald
    stuartarchibald committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    8a8fede View commit details
    Browse the repository at this point in the history

  2. Detect unsupport MAKE_FUNCTION use

    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    f92feaa View commit details
    Browse the repository at this point in the history

  3. Make PHI propagate unique definitions

    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    8ab1ab6 View commit details
    Browse the repository at this point in the history

  4. Fix up tests

    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    4b1c261 View commit details
    Browse the repository at this point in the history

  5. Fix problem with empty try-block

    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    e8b7ac6 View commit details
    Browse the repository at this point in the history

  6. Remove the unreachable return that is upsetting py2

    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    ccc1827 View commit details
    Browse the repository at this point in the history

  7. Revert "Make PHI propagate unique definitions" 

    This reverts commit 8ab1ab6.
    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    a815de1 View commit details
    Browse the repository at this point in the history

  8. Mark unsupport test to have closure inside try-except

    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    72182fd View commit details
    Browse the repository at this point in the history

  9. Skip test the needs scipy. 

    Move common skip scipy logic into support file
    @sklam
    sklam committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    b0d529e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Test and fix problem with type refinement 

    bug discovered by @esc
    @sklam
    sklam committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    316f3b1 View commit details
    Browse the repository at this point in the history

  2. Forbidden storing of exception objects

    @sklam
    sklam committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    79fb508 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Ban reraise in except

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    2664fcb View commit details
    Browse the repository at this point in the history

  2. Report the user variable

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    4f80bb5 View commit details
    Browse the repository at this point in the history

  3. Refactor similar code

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    fe4ef1f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-Authored-By: stuartarchibald <stuartarchibald@users.noreply.github.com>
    @sklam @stuartarchibald
    sklam and stuartarchibald committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    6bf1a1c View commit details
    Browse the repository at this point in the history

  5. Update numba/byteflow.py 

    Co-Authored-By: stuartarchibald <stuartarchibald@users.noreply.github.com>
    @sklam @stuartarchibald
    sklam and stuartarchibald committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    38d1a7a View commit details
    Browse the repository at this point in the history

  6. Test hack to fix old-style implementation's exception propagation

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    f127335 View commit details
    Browse the repository at this point in the history

  7. Remove dead code

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    04f1c08 View commit details
    Browse the repository at this point in the history

  8. Ban reraise in py38 properly

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    c1bb22f View commit details
    Browse the repository at this point in the history

  9. Fix issue with splitting LOAD_CONST. 

    Unexpectedly fixed test_closure4 usecases.
    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    6af3ef1 View commit details
    Browse the repository at this point in the history

  10. Apply review suggestion

    @sklam
    sklam committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    0a71334 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Merge branch 'master' into enh/tryexcept 

    # Conflicts:
#	numba/rewrites/static_raise.py
    @sklam
    sklam committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    a0b8d2b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: stuartarchibald <stuartarchibald@users.noreply.github.com>
    @sklam @stuartarchibald
    sklam and stuartarchibald committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    7f66bbe View commit details
    Browse the repository at this point in the history