Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some spelling typos #4909

Merged
merged 1 commit into from Dec 4, 2019
Merged

Fix some spelling typos #4909

merged 1 commit into from Dec 4, 2019

Conversation

bwignall
Copy link
Contributor

@esc esc added the doc label Nov 29, 2019
@esc
Copy link
Member

esc commented Nov 29, 2019

@bwignall thanks for submitting this, the fixes look good but seem to have caused some followup flake8 errors.

@bwignall
Copy link
Contributor Author

Thank you for highlighting that. I have added/squashed a commit that should handle that (a local flake8'ing showed the numba/tests/test_typedlist.py errors fixed and nothing in the other instances I checked).

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@stuartarchibald stuartarchibald added this to the Numba 0.47 RC milestone Nov 29, 2019
@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed doc labels Nov 29, 2019
@esc
Copy link
Member

esc commented Nov 30, 2019

@bwignall thanks for submitting the fixes, they do look good and seem to fix the CI errors with flake8 we saw previously!

Once small note: within the Numba project we tend to avoid using squash/rebase and force pushes after PRs have been reviewed so that we can track what happened during the review process. It isn't a big deal in this case, but please do keep that in mind should you decide to contribute more to Numba in future.

@stuartarchibald stuartarchibald merged commit 06c545a into numba:master Dec 4, 2019
@bwignall
Copy link
Contributor Author

bwignall commented Dec 4, 2019

@esc , I am sorry for that. Some, but not all, projects prefer squashing, so I should not have assumed beforehand. I will try to keep this in mind in the future. Thank you!

@esc
Copy link
Member

esc commented Dec 4, 2019

@bwignall no problem, thanks for being considerate, we appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants